Eric Erhardt

Results 266 comments of Eric Erhardt

This appear to only happen with the `3.1.0` nuget package. If I use the latest 3.1 version, `3.1.27`, it doesn't occur. Since we can't fix `3.1.0` (because nuget packages are...

RE: > [FAIL] Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled(colorBehavior: Default) Assert.Equal() Failure Expected: 1 Actual: 2 at Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled(LoggerColorBehavior) + 0x3ad at Microsoft.Extensions.Logging.Console.Tests!+0x8935ec at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x172 I cannot repro this error...

Occurred here again: https://dev.azure.com/dnceng/public/_build/results?buildId=1861609&view=logs&j=ac444259-14dc-5e9e-4846-f4aabcc22cf0&t=8b5dcf28-4222-5bb1-452d-824912c72244&l=29 https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-71501-merge-6f012c604d60484ca0/Methodical_others/1/console.d462ba5d.log?helixlogtype=result

I have responded to all existing feedback and pushed new changes. PTAL.

> I think offline you'd suggested a Create prefix... that might be better, even though it diverges from GetTempFileName. I went back and forth on using Create, or being consistent...

> I guess you can use [Path.GetRandomFileName()](https://docs.microsoft.com/en-us/dotnet/api/system.io.path.getrandomfilename?view=net-6.0) rather than a GUID. > If we use a Guid, I think NewGuid is a wrong option. On my windows machine, I'm not...

> ... and the objects are automatically cleaned up afterwards See the linked issue above - https://github.com/dotnet/runtime/issues/2048

> I wonder what the typical scenario is going to be: just creating the file or creating and using it right away. If the latter, we could make it more...

> What is the use case for why an empty file should be created by the File.CreateTempFile API? The same use cases for the existing `Path.GetTempFileName()` method today. > Name...

Since this is a regression from 5.0, we should backport this to 6.0.x.