Easwar Swaminathan

Results 540 comments of Easwar Swaminathan

Does your server logs contain anything useful?

Interesting. Is this from your server? But from the client logs, it seems like the client is not even sending one ADS request, right?

> Any idea how the changes post 1.65 could have affected this? There were a few changes that could be of interest: - https://github.com/grpc/grpc-go/pull/7458: This change causes the xDS client...

Thanks for the detailed report. So, if the stream errors seen by gRPC are not because of rate limit errors, does the istiod logs have anything useful about why it...

> ADS: new delta connection for node That is interesting. gRPC does not support the delta variant of the xDS protocol. gRPC currently only supports the SotW variant. So, maybe...

> https://github.com/grpc/grpc-go/pull/7347 requires quite some understanding of both grpc-go and istio xDS as to know how multiple named clients would work, when the agent doesn't seem to be aware of...

Thanks for filing the issue with istio. We do feel that it is a bug on the istio side to close xDS connections from gRPC other than the first one....

[gRFC A97](https://github.com/grpc/proposal/blob/master/A97-xds-jwt-call-creds.md) is a proposal to work around this issue and has been implemented in Go with the [following PRs](https://github.com/grpc/grpc-go/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+%22A97%22+). This should be part of the upcoming v1.77.0 release. @marcel808...

This came up during some other discussion with @dfawley. 1. Callback methods named `OnXxx` are more of a C++ style. In Go, we would probably just name them `Xxx`. 2....

Yes, I agree that we should not have checks for "resource-not-found" errors in the individual watchers. In fact, I'm thinking we might not even need those error types like `xdsresource.ErrorTypeResourceNotFound`...