Easwar Swaminathan

Results 540 comments of Easwar Swaminathan

Let me go over what we are looking to do here: - The `StubServer` type has a field in which it stores the actual underlying server, See: https://github.com/grpc/grpc-go/blob/8f920c6c56693bc53e526cd7f48e89ac250ff3a2/internal/stubserver/stubserver.go#L56C2-L56C3 - This...

Some more: ``` easwars@minetop: grpc-go$ grep -rl "func.*UnaryCall" * | grep -v .*pb.go authz/grpc_authz_end2end_test.go benchmark/benchmark.go binarylog/binarylog_end2end_test.go credentials/alts/alts_test.go internal/stubserver/stubserver.go interop/xds/server/server.go interop/test_utils.go orca/service_test.go stats/stats_test.go test/end2end_test.go test/xds/xds_server_integration_test.go test/channelz_test.go xds/internal/balancer/clustermanager/e2e_test/clustermanager_test.go xds/server_ext_test.go ``` ``` easwars@minetop:...

@janardhanvissa : Let me know what you feel about manually inspecting some of these files and figuring out which ones can be switched over to use the `StubServer`. Thanks.

@janardhanvissa : #7613 is now merged. So, what remains is the manual determination of which tests can be switched over to use the stubserver instead of implementing the test service,...

I would recommend starting with the simpler ones where you don't have to make such changes. Are there enough of those? Thanks.

No failures in 10K runs on Forge.

https://github.com/grpc/grpc-go/actions/runs/9134961110/job/25121494558?pr=7240

https://github.com/grpc/grpc-go/actions/runs/10395632530/job/28788092082?pr=7465

This is blocked until we bump the minimum Go version supported to `1.22` in our go.mod.

I see that we bumped up our minimum supported Go version to `1.22.7` in https://github.com/grpc/grpc-go/pull/7624. So, this should be unblocked. @marcoferrer : Would you be interested in making this change?...