Eduardo Apolinario

Results 268 comments of Eduardo Apolinario

@ChungYujoyce , I noticed that you shared an excerpt of a python exception, correct? From that it looks like you're using `ZipFile` to parse the zip file. Are you running...

@jsonporter , can you take a look?

Can you add some tests to https://github.com/flyteorg/flytekit/blob/master/tests/flytekit/unit/cli/pyflyte/test_run.py ?

Can you merge master to get rid of the failure in the unit tests?

@MortalHappiness , the implications of such refactor are far and wide as this has the potential to break multiple currently scenarios. In other words, this is going to require multiple...

@tomtou-bspace , this is a known limitation of the current implementation of map tasks. Unfortunately, we're not going to revisit this decision in the short / medium term as the...

The expectation is that the flytectl unit tests are going to fail.

This was added there to exercise the codepath used during [release](https://github.com/flyteorg/flyte/blob/bd3ed0d2684bddbc8fad1c26d4bc39a86e91077f/.github/workflows/create_release.yml#L45-L54) (notice how we only push to ghcr in a release). If you read the gh job `integration`, `build-docker` is...

Nice find! Thanks for taking a look. Let me confirm we don't really need those lines there.