ci: Remove duplicate docker-build job

[pingsutw]

Tracking issue

NA

Why are the changes needed?

We built the same docker image two times in the CI.

What changes were proposed in this pull request?

Remove duplicate docker-build job

How was this patch tested?

CI

Setup process

Screenshots

https://github.com/flyteorg/flyte/actions/runs/8965665995/job/24619590033

Check all the applicable boxes

• [x] I updated the documentation accordingly.
• [x] All new and existing tests passed.
• [x] All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.08%. Comparing base (0a1c82c) to head (a67a776). Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5327      +/-   ##
==========================================
+ Coverage   61.07%   61.08%   +0.01%     
==========================================
  Files         794      794              
  Lines       51203    51203              
==========================================
+ Hits        31271    31277       +6     
+ Misses      17049    17043       -6     
  Partials     2883     2883              

Flag	Coverage Δ
unittests-datacatalog	69.31% <ø> (ø)
unittests-flyteadmin	58.82% <ø> (+0.04%)	:arrow_up:
unittests-flytecopilot	17.79% <ø> (ø)
unittests-flytectl	68.30% <ø> (ø)
unittests-flyteidl	79.30% <ø> (ø)
unittests-flyteplugins	61.94% <ø> (ø)
unittests-flytepropeller	57.32% <ø> (ø)
unittests-flytestdlib	65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[eapolinario]

This was added there to exercise the codepath used during release (notice how we only push to ghcr in a release).

If you read the gh job integration, build-docker is a pre-req, but only for the flyteadmin integration tests here. What do you think of the idea of (1) restricting build-docker to only build the flyte-admin image and (2) create a separate gh issue to run the flyte-admin integration tests using single-binary in dev mode? (1) is expressed in https://github.com/flyteorg/flyte/pull/5331.