flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

feat(pyflyte): Remove the limit that pyflyte can only run files in current and nested directories

Open MortalHappiness opened this issue 1 year ago • 3 comments

Tracking issue

N/A

Why are the changes needed?

It isn't reasonable that pyflyte can only run files under current and nested directories.

What changes were proposed in this pull request?

Remove the limit that pyflyte can only run files in current and nested directories

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

Docs link

MortalHappiness avatar Mar 26 '24 10:03 MortalHappiness

Can you add some tests to https://github.com/flyteorg/flytekit/blob/master/tests/flytekit/unit/cli/pyflyte/test_run.py ?

eapolinario avatar Mar 26 '24 23:03 eapolinario

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.50%. Comparing base (6a63c1f) to head (3b14018). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
- Coverage   83.92%   83.50%   -0.42%     
==========================================
  Files         342      324      -18     
  Lines       25449    24672     -777     
  Branches     3717     3512     -205     
==========================================
- Hits        21357    20603     -754     
+ Misses       3462     3438      -24     
- Partials      630      631       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 26 '24 23:03 codecov[bot]

Can you add some tests to https://github.com/flyteorg/flytekit/blob/master/tests/flytekit/unit/cli/pyflyte/test_run.py ?

Done

MortalHappiness avatar Mar 27 '24 01:03 MortalHappiness