flyte icon indicating copy to clipboard operation
flyte copied to clipboard

ci: Reduce build times by 40%

Open pingsutw opened this issue 1 year ago • 1 comments

Tracking issue

NA

Why are the changes needed?

we didn't cache Go package in the CI

What changes were proposed in this pull request?

Upgrade setup-go to v4. V4 has enabled caching by default. https://github.blog/changelog/2023-03-24-github-actions-the-setup-go-action-now-enables-caching-by-default/

How was this patch tested?

CI

Setup process

Screenshots

Check all the applicable boxes

  • [x] I updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] All commits are signed-off.

Related PRs

NA

Docs link

NA

pingsutw avatar May 06 '24 09:05 pingsutw

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.08%. Comparing base (0a1c82c) to head (f848616). Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5328   +/-   ##
=======================================
  Coverage   61.07%   61.08%           
=======================================
  Files         794      794           
  Lines       51203    51203           
=======================================
+ Hits        31271    31276    +5     
+ Misses      17049    17044    -5     
  Partials     2883     2883           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (+0.04%) :arrow_up:
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.30% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.73% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 09:05 codecov[bot]

Amazing. Thank you!

eapolinario avatar May 06 '24 15:05 eapolinario