flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Fixup flytectl

Open eapolinario opened this issue 1 year ago • 2 comments

Why are the changes needed?

This PR brings the necessary changes to run flytectl CI changes in accordance with the model defined for the other components in the monorepo, including bumping the version of go (from 1.19 to 1.21).

This PR also renames the flytectl module and all its internal imports.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [ ] All commits are signed-off.

Related PRs

Docs link

eapolinario avatar Apr 30 '24 23:04 eapolinario

The expectation is that the flytectl unit tests are going to fail.

eapolinario avatar Apr 30 '24 23:04 eapolinario

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.20%. Comparing base (b55026e) to head (dd777d5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5309      +/-   ##
==========================================
+ Coverage   59.68%   60.20%   +0.51%     
==========================================
  Files         568      646      +78     
  Lines       41729    45654    +3925     
==========================================
+ Hits        24906    27486    +2580     
- Misses      14410    15576    +1166     
- Partials     2413     2592     +179     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 23:04 codecov[bot]

🎉

ddl-ebrown avatar May 03 '24 01:05 ddl-ebrown