Dawid Weiss
Dawid Weiss
[here's the gjf issue I asked for the direction they'd like to follow](https://github.com/google/google-java-format/issues/1193)
Let's wait a few days and see if there's any feedback. Like I mentioned above, what we use for formatting/checking format adherence shouldn't really matter for anybody who uses gradlew...
> They seem to be sometimes worse, sometimes better, and never more than about 0.002 different Could it be accumulated floating point errors?
The effort isn't lost - at least we know the benchmarks. I also am not particularly fond of this concurrent cache and blocking approach.
I agree this is a problem with wrapper/delegation pattern like Filter*. I can't remember the reason why this method was left non-final but it should be either this or the...
The problem isn't new - it's the same old issue that you can come across in FilterInputStream and other delegation-pattern classes in the JDK. Not all methods use delegate-forwarding there;...
My experience tells me that delegating everything in decorator-style classes leads to fewer headaches.
I am for making those classes delegate everything. And for adding a unit test. I've been using ArchUnit to statically verify this kind of thing in the past but it...
I've merged this in.
Thanks, it's one of the alternatives worth considering.