David Tolnay

Results 700 comments of David Tolnay

I reserved a `raw` field in f9fe7b8867920995ebced2ff5d45533145a508c8 to make this backward compatible in the future.

Syn already behaves pretty much exactly how you described. See below for demo. I skimmed through your macro and got a little lost, but I suspect the behavior you are...

Just happened in https://github.com/rust-lang/rust/pull/79213#issuecomment-730632811 without any race condition between two people. @rfcbot unchecked my box 1 second after I checked it.

Something like this is most likely to be okay for the foreseeable future. In exchange you'd be giving up support for asmjs and wasm and any other target without an...

Ah, seems to be blocked on https://github.com/rustwasm/wasm-bindgen/issues/1216. If you prefer, feel free to close for now and I can follow up later when the necessary functionality has landed in wasm-bindgen.

https://github.com/rust-lang/rust/issues/47384

Okay, so the bug motivating this PR was fixed already more than a year in advance of this PR being opened. I believe this PR should be closed.

CI failure appears unrelated. ```console Using default tag: latest Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading:...

Given that the repro code in https://github.com/near/borsh-rs/issues/19#issue-831009862 still compiles and still segfaults, and the bad unsafe in https://github.com/near/borsh-rs/issues/19#issuecomment-799594411 is still present in master, I would say no.

Specifically, the compiler's [`Span`](https://doc.rust-lang.org/proc_macro/struct.Span.html) which represents token location information is an index into a threadlocal interner to keep the size small so accessing a span from a different thread is...