David Tolnay comments

Results 700 comments of


                                            David Tolnay

Parsing an attribute

I don't completely follow what you are doing but it sounds like the thing you want is: ```rust f.attrs.push(parse_quote!(#[new_attr])); ``` Playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=c686a1aecdc0800b597d4ed2483e305a > Once I click through to `ParseStream` and...

Parsing an attribute

Labeling to make sure this gets covered in the Attribute docs.

Correct bounds processing for field types

We have some experience with the approach you are thinking of from experimenting with it in Serde 0.7. We ended up quickly going back to the approach shown in the...

Add attrs() and attrs_mut() getters to syn::Item

Seems reasonable. Please send a PR.

Parse const generic argument as ExprVerbatim when building without feature(full)

I guess I have the opposite perspective. Typically in custom derives you just need the field types to be shuffled from the input to the right places in the output....

Parse const generic argument as ExprVerbatim when building without feature(full)

Triage: I don't think we need to care about this until const generics are implemented in nightly.

Parse const generic argument as ExprVerbatim when building without feature(full)

Triage: still not available yet in nightly.

Write a test that counts the number of times visit_span is called

I see missing visit_span calls in: - fields of type TokenStream; - some variants of Lit; - punctuation of a Punctuated (#291).

Nested macro with attribute `internal_macro_calls` requires increasing in case of nested macro calls

I don't know of a way to fix this unfortunately, but I would accept a PR if anyone comes up with something.

Add more complex functionlike!(...) procedural macro example(s)

Thanks, this is useful feedback. Regarding Block::parse_within, yes the [documentation for that method](https://docs.rs/syn/0.15.3/syn/struct.Block.html#method.parse_within) says that it parses "the body of a block as zero or more statements, possibly including one...