Don Syme

The problem here is that the `get_Is*` declarations are not being added for union definitions that have a signature file (that is, they are being added for the implementation Tycon...

> The problem here is that the get_Is* declarations are not being added for union definitions that have a signature file (that is, they are being added for the implementation...

Two test failures in `fsharpqa` ``` 2021-08-10T22:29:40.9394729Z CompilerOptions\fsc\standalone (W_MissingTransitiveRef.fs) -- failed 2021-08-10T22:37:09.3159751Z Libraries\Portable (parse_tests.fs (Desktop)) -- failed ``` One test failure in `fsharp` - still a mismatch in surface area...

> @dsyme Thanks so much, it looks great! I just did a little minor tidying. If it looks good to you and the tests are green, I think we're good...

We do however need some more testing. * [x] We need to consider whether it's possible to hide the representation of a union by a signature but still reveal the...

@chkn I did some more work on this. Union case testers are programmer-visible in intellisense lists so are not marked "compiler generated" - instead there is a new flag for...

@psfinaki Basically this looks good, though I'd like to do some more on it next week to reap more benefit from the changes. I pushed some adjustments * Rename `CheckTypes.fs/fsi`...

Just to note that, once we iterate, this lays the foundation for further splitting, e.g. * `CheckAttributes.fs/fsi` for TcAttribute* and friends * `CheckTypes.fs/fsi` for TcType* * `GeneralizationHelpers.fs/fsi` (helpers related to...

Really good work!!! And so glad to see us making these core improvements

@edgarfgp @0101 Yay! 🥳 🥳 🥳