Don Syme
Don Syme
> I was wondering is this going be merged and how can affect performance? In short, we don't know the answers to these. Merging is probably unlikely without specific concrete...
OK thanks, yes I didn't get that when I tried in Ionide but I think the project context wasn't loaded correctly
@vzarytovskii @KathleenDollard Reviewing things, this seems like really low hanging fruit for improving VS
> @dsyme Do you have any opinions on the treatment of Object.ReferenceEquals(x, null), where null is inferred as obj? I don't see how to suppress the "obj inferred" warning for...
@Smaug123 No, we don't need to worry about this warning in the compiler, thanks
Subtle introduction of the bug. Marking `CompilationPath` as `NoEquality` may help track track this down, looks like it is the structural equality on this: ```fsharp [] type Accessibility = |...
By using this diff https://github.com/dotnet/fsharp/compare/main...dsyme:cwe?expand=1 it looks like these are the origin points for structural equality ``` let isPublicVal (lv: Val) = (lv.Accessibility = taccessPublic) let isPublicUnionCase (ucr: UnionCaseRef) =...
@Happypig375 Thanks for the +1. I'd love your thoughts on how we can improve things further.
> You're welcome. "shortDigits@54-2" -> "shortDigits@line54closure2" would be more understandable for beginners? Maybe `shortDigits@54-2` -> `shortDigits@line-54-closure-2`
> Can we emit spaces? `shortDigits @ line 54, closure 2` In theory I think yes