Don Syme
Don Syme
> @dsyme, do you want to use spaces or hyphens? I'm genuinely not sure, let's discuss here https://github.com/dotnet/fsharp/issues/12366#issuecomment-974232138 We could accept this PR as it represents an improvement as far...
Baselines will need updating
This is by design per RFC https://github.com/fsharp/fslang-design/blob/main/FSharp-4.5/FS-1053-span.md An explicit Out attribute is needed Will change to a diagnostic suggestion
I thought about this again and agree we should do something here to make this consistent between F# and IL definitions.
@edgarfgp Thank you so much for checking! I've checked too and it seems both are fixed - with the first issue, two warnings were being generated - one for incomplete...
@vzarytovskii This is ready
I'd like to see more testing of the language as well please, e.g. - `namespace rec` where the `Is` properties are used _before_ the definition - test the quotation of...
I fixed the build here, will now review
> I fixed the build here, will now review Everything looks totally fine with this, I think we should go ahead and merge it into preview once it is green...
@chkn An unexpected test failure - the surface area of FSharp.Core has changed, with these unexpectedly missing: ``` 2021-08-09T16:37:19.9718691Z Microsoft.FSharp.Collections.FSharpList`1[T]: Boolean IsCons 2021-08-09T16:37:19.9719223Z Microsoft.FSharp.Collections.FSharpList`1[T]: Boolean IsEmpty 2021-08-09T16:37:19.9719739Z Microsoft.FSharp.Collections.FSharpList`1[T]: Boolean get_IsCons()...