Don Syme

Results 1218 comments of Don Syme

@brettfo Random test failure, we takled about this one ``` The active test run was aborted. Reason: Test host process crashed : go Unhandled exception. System.Threading.Tasks.TaskCanceledException: A task was canceled....

Failing test ``` CodeGenRenamings01 ```

> @dsyme, in some of the code, it looks like | null turned into a new | Null . > > Is there some background information on how they are...

I merged main into this but it is going to take quite a lot of work to get it compiling and green again :)

> It can be very handy when debugging something parser-related, please leave a least some way to keep it like this. You we should add a debug property with full...

Discussing this with @NinoFloris - the intention of the overall design is to rule out the use of the union case holder The logic [here](https://github.com/dotnet/fsharp/blob/main/src/Compiler/TypedTree/TypedTreeOps.fs#L8917-L8926) should be recursively checking the...

Tricky problem, cf. min/max: ``` > max nan 1.0;; val it: float = nan > max 1.0 nan;; val it: float = nan > min 1.0 nan;; val it: float...

Noting List, Array, maxBy, minBy also have this problem @vzarytovskii I do think this should be fixed. Labelling as good-first-issue

My understanding is min and max should return NaN in all four cases. We should compare with LINQ

LINQ is an odd mix, seemingly making NaN the lowest number, so it only affects Min, not Max. See https://sharplab.io/#v2:C4LgTgrgdgNAJiA1AHwAICYCMBYAUKgBgAJVMA6AGQEsoBHAbjz1QGYT0iBhIgbzyIEk2pAGwkALEQCyAQxoAKUgQDaAXSIywAcwBuASl79Bx0gE558qAFMA7kTgB7CACMANlbW97Tt1bIA5GX8YInQyAhCWcKIAXz0yWQAPeT09RlxjE0xzS1tvF3dPHiIoiPzfAKCQsOI4hJlk1PTMwTMLaztHAo91YtKQrorA4NDouqkFJqMWttzOn0LekvCBhb9h6rH4iagUtOnYvBigA=== Systematic alignment with LINQ Max() and Min() seems wise. Or...