Don Syme
Don Syme
See https://github.com/dotnet/fsharp/pull/6805/commits/5603467ffe69339cc45cbe3aa60dc837578c953e for extensive additional testing, and there is a feature adjustment which I will write into the RFC
> I think the cache mechanism for IncrementalBuilders means that for a given project only one builder will be created, even if many dependents will try to process it at...
@safesparrow I can't merge to your branch, can you merge main into this please?
@safesparrow Thanks!
@safesparrow Actually it's showing it's needs another merge (normally we can update but for some reason your branches don't allow it)
You seem to need to keep merging, my apologies.
Interesting problem, thanks. Yes we should at least emit a warning when this happens, and consider how we can allow explicit qualification so `FSharp.Core` doesn't come into scope.
This uncovered a case where the F# compiler is incorrectly deciding to not emit a tailcall I will look into this and fix it and then see if this goes...
It's interesting that this passes now. It's possible we should use this on .net core. I'll do some perf measurements.
Yes, we should merge it at some point. I'm not sure what other validation to do though. I'll get back to it.