dswij comments

Results 94 comments of


                                            dswij

Feature: Implement the Body trait for more native data types to improve ergonomics

> I've been personally torn on this. I appreciate the explicitness of having `Full`, and I kind of regret that we stabilized with an implementation on `String`. > > So,...

`needless_return` has false negative pattern

@rustbot claim

fix: insufficient buf size when reading windows named pipe message

Ah, yeah. Forgot to set up formatting in the windows machine :)

fix: insufficient buf size when reading windows named pipe message

The change passed Tokio's test suites, but the CI is failing on unexpected cfgs. I opened a [PR](https://github.com/tokio-rs/mio/pull/1785) to handle this, unless you have other ideas for the unexpected cfgs...

Fix `match_single_binding` wrongly handles scope

Sorry, was buried with things to do past two weeks. Thanks for the ping! :)

Rewrite `lifetimes` lint pass

r? clippy

Clarify that `modulo_one` only applies to ints

Thank you! @bors r+

Clarify that `modulo_one` only applies to ints

@bors r+

Add new lint `shadow_type_generic`

r? clippy

HTTP2 Max Streams aware client pooling

That's a fair ask. I'll get into it as soon as I have time to spare.