dswij comments

Results 94 comments of


                                            dswij

Don't trigger `const_is_empty` for inline const assertions

Thank you! @bors r+

Don't trigger `const_is_empty` for inline const assertions

@bors retry

`Uri` shouldn't accept curly braces (`{`, `}`) in path parts

Seems like the curly braces were made valid after https://github.com/hyperium/http/pull/474 with the comment on why it was accepted. I agree that most usage doesn't accept curly braces as valid characters....

graceful shutdown does not shutdown when i use Google Chrome。

Should be fixed by https://github.com/hyperium/hyper-util/pull/101 once that's out.

feat(http1): add option allowng leading whitespaces before first header

Yes. This PR is waiting for a new release of httparse to include the httparse changes you mentioned.

docs(examples): add an example of handler based routing

> I am curious- I noticed that the other examples tend to contain fairly few comments. Is this intentional? I won't say it's intentional. More likely, the author thought the...

Add new lint [`manual_checked_sub`]

r? @samueltardieu Hope you don't mind since you reviewed this and are now a part of the clippy team :).

Fix `redundant_closure` suggests wrongly with deref overload

Thank you!

Add `clippy::self_only_used_in_recursion` lint

r? clippy

Add API for poisoning connections

Did you run it with `--all-features`? @rcoh