dswij comments

Results 94 comments of


                                            dswij

Add `manual_filter` lint for `Option`

Thanks for this! @bors r+

Create a hyper::error::Code type

Since this is related to https://github.com/hyperium/hyper-util/pull/3, figured I'll take a look at this. One thing I'm not too sure of is: how exactly does this `Code` differ from `hyper::error::Kind`?

`manual_flatten` false positives with reference slices

In addition to the original issue, `manual_flatten` also seems to give false suggestion on ```rust fn main() { for n in [&&Some(1)] { if let Some(x) = n { println!("{}",...

`manual_flatten` false positives with reference slices

@rustbot claim

Add new lint `paths_from_format`

@merelymyself Thanks for the changes! Sorry for the delay, I will try to get into it this week.

Add new lint [`positional_named_format_parameters`]

Thanks for the PR and welcome! Sorry, haven't had the time to take a look at this. I will get to it asap this week when I have the time

Add new lint [`positional_named_format_parameters`]

I believe `clippy` uses the toolchain version defined here: https://github.com/rust-lang/rust-clippy/blob/master/rust-toolchain. The job failed when trying to apply the fix for the lint 😕. Did this pass on your local machine?

Add new lint [`positional_named_format_parameters`]

That makes sense. We can wait for the weekly sync then. The next scheduled one is pretty soon (by the next 24 hours). We can come back and rebase the...

Add new lint [`positional_named_format_parameters`]

Huge thanks for this @miam-miam100! This is a nice lint to have for sure. @bors r+

Ignore `match_like_matches_macro` when there is comment

Thanks for the review! @bors r=@flip1995