dswij comments

Results 94 comments of


                                            dswij

lint matchable `if let` for pattern

Yes, exactly. Suggest `matches` if it doesn't implement `PartialEq`. I'm trying to think of scenarios where suggesting `matches` would be wrong, but I'm having trouble coming up with one. Just...

clippy::question_mark lint suggests code that does not compile

This is fixed in nightly in #8080 ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e1d374fa32f2a278d463852fd8f51420)), but I can confirm this is a problem in 1.58.0

`read_zero_byte_vec` emitted when `read` is in the next block

@rustbot claim

`read_zero_byte_vec` emitted when `read` is in the next block

@pac-work the lint only fires for `Vec::with_capacity`, `Vec::default`, or `Vec::new`. It won't fire with `vec![]` inits.

Added the `[unnecessary_box_returns]` lint

r? @xFrednet I've rebased this and update some outdated stuff. This should be ready to go, any improvements can be in future PRs since this is going to nursery. Would...

check if closure as method arg has read access in [`collection_is_never_read`]

Thank you! @bors r+

Make `single_range_in_vec_init` ignore type annotations, fn arguments and `ExprField`s

Just a friendly ping to check in on the progress and if you need any help to move it forward @matzemathics :)

Check for try blocks in `question_mark` more consistently

Thank you! @bors r+

Client receives `unexpected end of file` randomly

I assume the UnexpectedEof you encountered is on a server. This should be fixed by #743. > eventually the client sends an frame END_STREAM which afaik should close the stream...

Client receives `unexpected end of file` randomly

> It's not outgoing responses from a server that have this issue if that's what you mean. Thanks for the clarification. #743 won't fix this if this is the case....