Results 94 comments of dswij

Thanks for the PR! Sorry I haven't been able to take a look at this. I will get to it asap this week when I have the time

> The lint itself is fine, but it requires placement syntax before it's generally applicable. As far as I know that's completely stalled as of now. `Box::new(foo())` can't optimize out...

So, I ran this lint on 250 crates: # Summary ## Build failures Total: 1 - vsdb-0.45.2 ## Warnings Total: 17 Crate | Count :------------------------|------: bincode-1.3.3 | 4 clap-3.2.15 |...

No rush. Feel free to ping me when it's ready

hey @botahamec, sorry to nag, but it seems like there's not a lot of activity on this PR lately. Let me know if you don't have much time, and I...

@Guilherme-Vasconcelos Huge thanks for this! This lint is certainly nice to have. @bors r+

We can use [`equatable_if_let`](https://github.com/rust-lang/rust-clippy/blob/d7e5dab6c38aa0dc8aa93dd56734b3ba6e32063f/clippy_lints/src/equatable_if_let.rs) as a starting point, this should be a good first issue

Also, the logic would also be similar to [`match_like_matches_macro`](https://rust-lang.github.io/rust-clippy/master/#match_like_matches_macro).

I haven't taken a deep look into it, but if we plan to add this to a new lint, we can factor out reusable logic from `equatable_if_let`. Alternatively, we can...

@nahuakang it seems like it won't fire if `PartialEq` is not implemented. See ([playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=2d6cadfff9f95c52799ed27409769df6)). The test cases for this lint seems to agree. Makes sense since if `PartialEq` is not...