David Snopek

Results 410 comments of David Snopek
trafficstars

Thanks! Could you rebase this on the latest `master`? I want to see CI run successfully before merging, but this has the old MacOS environment which is breaking CI, which...

Looks like `actions/cache` was already updated and `actions/upload-artifact` was done in PR https://github.com/godotengine/godot-cpp/pull/1335, so closing this one

Thanks! This looks good at a first glance :-) > this isn't technically dependant on the aforementioned PR (though it does lift the internals & `constexpr`) I'd still prefer to...

Perhaps we could document it on [this page](https://github.com/godotengine/godot-docs/pull/9250) after it's been merged?

Ah, probably PR https://github.com/godotengine/godot-cpp/pull/1381 I think we probably need a general way to record behavior changes for godot-cpp. We're generally OK with making these sort of bug fixes and even...

Yeah, when it's a `float` in Godot's C++ API, GDScript's `double` would be converted to a `float` at some point anyway. Here it's a question of how we expose Godot's...

I spent a little more time looking at this, including diff'ing the `gen/` directory both before and after this PR, to make sure the changes match expectations. Everything is looking...

The failing CI will be fixed by PR https://github.com/godotengine/godot-cpp/pull/1486 - it's unrelated to these changes

Discussed at the GDExtension meeting: we agreed that this change makes sense, and additionally that cherry-picking would be OK, given that developers still need to update to a newer version...