David Snopek

Results 410 comments of David Snopek
trafficstars

> ...the CI tests are failing with the same error on this other recent PR too: https://github.com/godotengine/godot-cpp/actions/runs/8852986336/job/24312834460?pr=1450 Try rebasing on `master`. The changes from PR https://github.com/godotengine/godot-cpp/pull/1461 may have fixed the...

Thanks! Unfortunately, it looks like this needs another rebase to address conflicts in `SConstruct`

@Ewall198 Looking back on the previous comments, it seems like the PR was basically acceptable, it just needs a rebase to (hopefully) fix CI issues and resolve conflicts that have...

Using `long` as an argument on a bound method actually seems to work for me on Linux with GCC 11.4. I'm a little surprised, though! We don't provide a version...

> Or maybe define them to something so they raise a much clearer error that says to use the fixed width versions? This would be nice, although, I'm not sure...

I just posted PR https://github.com/godotengine/godot-cpp/pull/1590 which should fix this! If anyone has time to test it with their project, I'd appreciate it :-)

@zero334 Could this be related to the issue on MacOS where reload doesn't work if using relative (rather than absolute) paths in the `.gdextension` file? See https://github.com/godotengine/godot/issues/90108#issuecomment-2400353562

Thanks! While this does seem like a DX improvement, I'm not sure about adding it to godot-cpp, when Godot modules won't have access to this. One of godot-cpp's design goals...

> Otherwise, I'm totally ok to close this and just stick to using it internally within my own modules You could also make it as a separate header-only library in...