godot-cpp icon indicating copy to clipboard operation
godot-cpp copied to clipboard

Replace generic macros with math equivalents

Open Repiteo opened this issue 1 year ago • 1 comments
trafficstars

godot-cpp counterpart to godotengine/godot#91324

As this is already largely implemented on godot-cpp's side already, this isn't technically dependant on the aforementioned PR (though it does lift the internals & constexpr). Rather, this focuses on converting whatever remaining macro instances existed with their math equivalents, and labeling the macros as deprecated.

Repiteo avatar Jun 24 '24 16:06 Repiteo

Thanks! This looks good at a first glance :-)

this isn't technically dependant on the aforementioned PR (though it does lift the internals & constexpr)

I'd still prefer to wait until the Godot PR is merged, so that we can be sure this PR is sync'd with the latest version of the code there

dsnopek avatar Jun 25 '24 14:06 dsnopek