David Smiley
David Smiley
References to JavaVersion (a Gradle class) like `>= JavaVersion.VERSION_16` should be reviewed to see if we can make changes to remove conditions that will no longer vary. Searching for "Java...
Thanks so much Ishan & others! I mean that super sincerely... But I've got to say, it's premature to merge a PR without either first seeking and getting another approval...
I'm only "blaming" you for not following a best practice (twice now) on big/important PRs. Nothing more. If neither broke things I wouldn't be happy but probably wouldn't have said...
I'd like to contribute to this PR to replace the ThreadLocal with a re-using pool that we mostly already have.
Note that "api" module should also be Java Language 17, as it's included with SolrJ.
Nice work. I toyed with it a bit, including tinkering with toolchains. Avoiding toolchains avoids IntelliJ's Gradle's check to tell you that we really should be using a newer Gradle...
Why aren't we using toolchains?: https://docs.gradle.org/current/userguide/toolchains.html
The Docker build.gradle needs to refer to a JDK 21 base image, not JDK 17. BTW, when I checked out your branch and before I tinkered with it, I simply...
> However, jar task is still, I think ,running with whatever java_home is It's normal & acceptable that the entire build itself do JAR packaging etc with the same running...
I might have misunderstood Toolchains; if it means having additional JDKs around then I don't think we want to require that. It's sufficient to have only JDK 21 and configure...