David Smiley

As I mentioned, IntelliJ isn't recognizing the language distinction between tests vs non-tests so I recommend simply using the same language per module. Other than that, I suppose it's ready...

I see; it works!

Sadly the PR diff is now confusing; seems to have dependency updates and stuff from main but GitHub isn't detecting/realizing that this PR shouldn't be bringing such changes if merged....

No please don't create yet another PR just because the diff isn't looking clear. I've already reviewed everything so I recommend a rebase & force push. You're super close to...

> We're on commons-io 2.15.1? We should upgrade to 2.16.1 in this PR, since you're already looking at it and I remember that some stream closing behavior changed between these...

@madrob I made further changes based on your comments in the schema designer. LMK what you think. Otherwise I think it's mergeable (no JIRA).

I'm looking at #2527 and #2672 (this one) which seem the same at a glance; why do we have two PRs? It's really sad this didn't get merged before 9.8....

`crave run -- ./jmh.sh CloudIndexing -jvmArgsAppend -Dsolr.bench.seed=823716671780822 -p useSmallDocs=true -p nodeCount=1 -p numShards=1 -p numReplicas=1 -I 8` The benchmark module uses JettySolrRunner via MiniClusterState. Googling for this is inconclusive as...

Maybe you are unfamiliar with Log4j but look at log4j2-bench.xml in this module.

Wow; good find! If `setMaxConnectionsPerDestination(1)` then what? I wonder what Jetty is supposed to do when this limit is approached -- like is cancel_stream_error expected in some sense or should...