David Smiley

Before this change here, isn't there some existing build image for Solr you @uvatbc worked on ? @iamsanjay assuming the build starts running on JDK 21 (wherever -- CI /...

@uvatbc thanks for offering to help further (edit our build) if you wish but I wouldn't want any feedback on these PRs to be implied that it is for you...

@iamsanjay as this just adds a file, maybe you should simply include it in #2682 as you are touching other CI files there as well so why not.

Oh nevermind; it's already there :-) I'll close this PR; thanks @uvatbc

"Context" and "Scope" are almost synonymous... "Context" just potentially holds more than a scope. I'm not sure a rename is warranted; let's table that. Better to do big renames at...

Remember AB's [comment](https://issues.apache.org/jira/browse/SOLR-17458?focusedCommentId=17941031&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17941031). To add/clarify something he's getting at is the need to unregister metrics related to a core. The DropWizard MetricsRegistry per core was a way to do that....

We don't need an attribute for the registry so long as our metrics are reasonably differentiated / clear. We can change our mind in the future with basically no disturbance,...

`URIBuilder` is in the Apache HttpClient dependency, using it goes in the opposite direction we're trying to go in! Granted in tests, this isn't a priority, so this PR is...

> @SuppressForbidden(reason = "") //Still need to decide what the message should be for all. Thinking of adding "Deprecated in Java " Ideally those are addressed for real, otherwise they...

I suggest flipping the order. Prep the code for Java 21 compatibility first so that we don't go adding SupressForbidden to many classes to only then fix the issue later....