Dave MacFarlane

Results 249 comments of Dave MacFarlane

has conflicts, I'll send a different PR since @ridz1208 isn't here to update it.

No, I thought I had already removed it from the release.

That stack trace has a project/libraries/NDB_BVL_Battery.class.inc file in it. Are you sure you don't have overrides that are breaking @skarya22's change?

@skarya22 can you rebase this? There is a conflict

@skarya22 There are still conflicts that prevent this from being merged

I think in other modules this is solved by sending the max size from the php.ini settings to the frontend and verifying that the scan can be handled in the...

When looking for an example I found that this module is one thats already supposed to do that: https://github.com/aces/Loris/blob/main/modules/imaging_uploader/jsx/UploadForm.js#L357-L360 Might be server setup related.

@ridz1208 That sounds reasonable to me.. I'm surprised it's not already data frameworkified, but you're right, it's not, so that would probably be best.

The problem isn't that it fails when Active='N', the problem is that it fails when it's not on the file system (even if it's inactive)

This was discussed at the LORIS meeting. Instead of making modifications to the "My Tasks" widget, a different widget for "My Issues" will be added which shows open issues currently...