Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[ModuleManager] when it's set to Active:no - page fails to load

Open christinerogers opened this issue 1 year ago • 5 comments

Basically this module should never be configured to Active:No -- but it should still fail a bit more elegantly here on the off chance it is.

currently it loads with a blank page saying "this module could not be found" if it's set to Active:no (in the modules table i think)

found during C-BIg testing may 9. filed a bug after discussion with @ridz1208 and Dave.

christinerogers avatar May 09 '24 14:05 christinerogers

The problem isn't that it fails when Active='N', the problem is that it fails when it's not on the file system (even if it's inactive)

driusan avatar May 09 '24 15:05 driusan

@driusan maybe it can be a try catch to get the module info and if it fails it can just replace with NA or some other message

ridz1208 avatar May 09 '24 15:05 ridz1208

still seems like an important bug (did not test)

christinerogers avatar Sep 17 '24 15:09 christinerogers

@driusan @christinerogers I agree that this module shouldn't be set No; But I am getting the below attached attached message when set to 'No'..

Image

What is the fix we need to implement here. I am little confused.

sruthymathew123 avatar Oct 07 '24 19:10 sruthymathew123

Could probably be fixed if the changes in https://github.com/aces/Loris/issues/7083 were implemented.

charliehenrib avatar May 02 '25 13:05 charliehenrib