Dave MacFarlane comments

Results 249 comments of


                                            Dave MacFarlane

[smarty] Allow instrument tables to expand off-screen

Is this intended for the main or 27 branch?

[DQT] - Query not run yet

Can you also check if there is an error in the browser console? Sometimes when there's an error/something crashes it says the query hasn't run yet.

instrumentqueryengine doesn't handle null response to getFullName

Thank you for the detailed report. Without having had time to look into it in depth a couple quick points: 1. the _status field names are special in LORIS and...

[DQT] Unknown error in PHP log

This looks like a problem with the history table for very large queries (>64kb of json). `history.new` is text datatype. `dataquery_queries.Query` is JSON (longtext).

[candidate_profile] Can see consent card without Candidate Parameters permissions

Is that the right permission? Or should there be a separate permission? Should there be any permission required to view consent status? I think anyone who accesses the candidate probably...

[candidate_profile] Can see consent card without Candidate Parameters permissions

Assigning this to myself as a place-holder

[candidate_profile] Can see consent card without Candidate Parameters permissions

A consent permission is added in #7583 which should be used after that is merged.

[SQL] 9999-99-99-drop.sql - fix can't delete by foreign key constraint

@regisoc GitHub suggests you to review. Can you review?

[Media] - can't show hide file by current user.

Why did you expect to see the file with red colour? The test plan says "Delete files. Deleting a file hides it from the frontend, but preserves a copy in...

Add the MRI variables in the imaging_browser's query engine

Was replaced by #9824