Drew Johnson

Plugin hook for initial axial expansion

6

There isn't an easy way to override the initial axial expansion performed on assemblies at construction. Providing a mechanism like this would be useful. I propose a plugin hook like...

HexBlock.rotate updates child spatial locators

4

## What is the change? Calls to `HexBlock.rotate` update the spatial locator on all child components. This is necessary because you'd expect rotation to move things in space. Tests are...

Provide a method for determining center locations of children on a block

1

I know this isn't part of your design, but maybe this method could take an optional `flag` parameter that defaults to `Flags.CLAD`. That way, if in the future someone wants...

Extensibility improvements to axial expansion classes

1

## What is the change? A handful of improvements to allow subclasses of axial expansion things more control. A general theme was to take large methods and break them up...

Block.getNumPins broken for C5G7 model :: multiple cladding components per lattice site

1

If you load the C5G7 test reactor and grab an assembly, you get a hilariously large number of pins ```python >>> r = armi.init(fName="armi/tests/c5g7/c5g7-settings.yaml").r >>> fuelBlock = r.core[0][0] >>> fuelBlock.getNumPins()...

Update spatial locations after HexBlock.rotate

1

Replaces #1860 because a [decision](https://github.com/terrapower/armi/pull/1877#issuecomment-2400277764) has been made to not rotate data parameters. Instead 1. update the spatial location of components through rotation. 2. enforce that, for pin-like data parameters...

Insufficient testing on buReducingAssemblyRotation

2

ARMI provides functionality for a fuel handler to do "burnup reducing" assembly rotation https://github.com/terrapower/armi/blob/f1f3dbea05c2564404a03d8e053f72c2af15daa9/armi/physics/fuelCycle/assemblyRotationAlgorithms.py#L38-L40 https://github.com/terrapower/armi/blob/f1f3dbea05c2564404a03d8e053f72c2af15daa9/armi/physics/fuelCycle/hexAssemblyFuelMgmtUtils.py#L32-L41 The testing for this functionality is lacking, in my opinion; it checks that that the...

HexBlock.autoCreateSpatialGrids raises lots of spurious exceptions

6

It's not uncommon for me to see messages like ``` [warn] Could not create a spatialGrid for block BLOCK, multiplicities are not 1 or N they are {1} ``` which,...

Allow axial expansion related classes to be more extensible

4

I'm working on some internal axial expansion work and finding myself needing to modify some of the functionality on the base class. In some cases I can call `super` and...

Provide more Composite.iter* methods

4

ARMI does a lot of iteration over the composite tree. Understandably so, we have lots of methods that support iterating over children of an object, with some filtering. These usually...