terrapower
Extensibility improvements to axial expansion classes
What is the change?
A handful of improvements to allow subclasses of axial expansion things more control. A general theme was to take large methods and break them up so subclasses can override at their discretion.
Some documentation has been added to axial expansion related classes. It's by no means complete, nor to the level of #935. But as I fumbled through the code and got helped from @albeanth, I added what I could to the docstrings.
Why is the change being made?
I am working on features internally that need more control over performing axial expansion that require these changes.
Closes #1453
Closes #1918
Checklist
- [x] This PR has only one purpose or idea.
- [x] Tests have been added/updated to verify any new/changed code.
- [x] The code style follows good practices.
- [x] The commit message(s) follow good practices.
- [x] The release notes have been updated if necessary.
- [x] The documentation is still up-to-date in the
docfolder. - [x] The dependencies are still up-to-date in
pyproject.toml.
@john-science this PR is apart of a larger downstream internal change, so please hold off on merging this. thank you!
Holler when you guys want this merged. I see it is doubly approved.
This is getting run on additional downstream testing. If all goes well, it should be good to go today. I'll ping you when we're ready.
@drewj-tp I see this as approved, and we have a release coming up. Any status on when this might get merged?
@drewj-tp I see this as approved, and we have a release coming up. Any status on when this might get merged?
Same status as yesterday. Blocked by downstream testing going awry. @drewj-tp, @mgjarrett, and myself need to troubleshoot today.