armi icon indicating copy to clipboard operation
armi copied to clipboard

Update spatial locations after HexBlock.rotate

Open drewj-tp opened this issue 1 year ago • 1 comments

Replaces #1860 because a decision has been made to not rotate data parameters. Instead

  1. update the spatial location of components through rotation.
  2. enforce that, for pin-like data parameters like Block.p.linPowByPin, the data at index i is defined at Block.getPinCoords()[i],
  3. setters like Block.setPinPowers are no longer needed and just set the data parameter directly.
  4. discourage the usage of Block.p.pinLocation

drewj-tp avatar Oct 08 '24 16:10 drewj-tp

@john-science has thoughts on updating the Block.grid object through rotation, which feels appropriate to bring up here. Namely we should update the Block.grid

drewj-tp avatar Oct 08 '24 16:10 drewj-tp