Drew Johnson

Results 55 comments of Drew Johnson

Two cents: `R.nuclides` over `App.nuclides` Rationale: interfaces always have access to the reactor, not necessarily the application. And the app is already a global thing, so putting the nuclides there...

Talked with @john-science and I wanted to clarify something that I missed in the initial review > The pins would be incorrectly rotated to the "corners up" grid rotation, even...

> @drewj-tp I need to disambiguate. You say: > > > My main concern is that `Block.spatialGrid` should be the grid on which its children live. > > But below...

Can we use `abc.ABC` with namedtuples? It's inherited in a couple places and has some abstract methods Maybe possible. I don't have experience subclassing namedtuples

Maybe [`dataclass`](https://docs.python.org/3/library/dataclasses.html)? I tend to prefer those if I want to make a simple class that is more akin to a c style struct. There's some discussion in the PEP...

> Whatever you end up implementing here (I did not read this ticket in extreme detail), please make sure you consider this PR: https://github.com/terrapower/armi/pull/1376 I think this will introduce functionality...

> yes we can remove max burnup if thats desired. Okay. It's desired because we have two ways of defining the same concept right now, and that's not helpful for...

I'm going to fold this into the ongoing assembly rotation work (#1921) because the `Block.p.percentBuMax` and `Block.p.percentBuMaxPinLocation` parameters were only used for that feature https://github.com/terrapower/armi/blob/864106e1da0501bee13489c223b950a80906ab25/armi/physics/fuelCycle/hexAssemblyFuelMgmtUtils.py#L83

> So, I think you are seeing MAX, and want to see MIN That makes sense to me. > But it is written so that people see AVERAGE and MAX...