Block.p.percentBuPeak should replace Block.p.percentBuMax
Talked with @onufer this morning on my confusion between Block.p.percentBuMax
https://github.com/terrapower/armi/blob/864106e1da0501bee13489c223b950a80906ab25/armi/reactor/blockParameters.py#L139-L145
and Block.p.percentBuPeak
https://github.com/terrapower/armi/blob/864106e1da0501bee13489c223b950a80906ab25/armi/reactor/blockParameters.py#L796-L802
Looking at their metadata, they feel very similar and redundant. @onufer indicated the "peak" parameter is a bounding burnup that could supersede percentBuMax as the metric for "maximum burnup for something in this block"
If I'm understanding his summary, that seems like a good argument for removing Block.p.percentBuMax.
We should also add the depletion category to the Block.p.percentBuPeak categories so it can be tracked and reported w/ other depletion parameters
This feels like a simple enough of a request that could be completed with #1990
yes we can remove max burnup if thats desired.
yes we can remove max burnup if thats desired.
Okay. It's desired because we have two ways of defining the same concept right now, and that's not helpful for devs, analysts, users, anyone
I'm going to fold this into the ongoing assembly rotation work (#1921) because the Block.p.percentBuMax and Block.p.percentBuMaxPinLocation parameters were only used for that feature
https://github.com/terrapower/armi/blob/864106e1da0501bee13489c223b950a80906ab25/armi/physics/fuelCycle/hexAssemblyFuelMgmtUtils.py#L83