Daniel McCloy comments

Results 823 comments of


                                            Daniel McCloy

Add `colorbar` parameter to `mne.viz.plot_topomap()`?

@NadipilliAditya there's already an open PR #13187 that addresses this one.

`info['subject_info']['birthday']` date type

I think we should detect if it's `pd.Timestamp` and if so call its `.date()` method to convert to standard `datetime.date`. Ideally do it using `hasattr` so we can avoid importing...

Export as vector based graphics (SVG, EPS, PDF) throws an error for Evoked.plot()

@AasmaGupta you are welcome to work on it. Before I assign you though, can you do as @agramfort suggested to isolate whether the bug is actually in MNE-Python or in...

Export as vector based graphics (SVG, EPS, PDF) throws an error for Evoked.plot()

It can actually be quite a bit simpler! I still get the error with this: ```py import numpy as np import matplotlib matplotlib.use("Agg") import matplotlib.pyplot as plt from matplotlib.widgets import...

Export as vector based graphics (SVG, EPS, PDF) throws an error for Evoked.plot()

just reported upstream!

Optimize head placement in viz.plot_evoked() when spatial_colors=True

I think we rely on matplotlib's algorithm for picking the "best" position, but I think it might only consider corners, not sides. how does it look without the GFP, does...

DOC: show example code for custom reader functions (was: Subclassing BaseRaw is too difficult)

> Maybe it could be turned into an example? exactly what I was thinking; I'll re-open and re-title this issue as an issue about doc improvement. > FWIW, what's really...

DOC: show example code for custom reader functions (was: Subclassing BaseRaw is too difficult)

> I think the `.npy` reader could be used for the example, but I don't think I will have time to add the "few more pieces". I'm not sure if...

DOC: show example code for custom reader functions (was: Subclassing BaseRaw is too difficult)

> Also, in your example I think subclassing `BaseRaw` is really essential, otherwise there's no way to set the `.filenames` attribute. This is what brought us here in the first...

Missing aria-current

SGTM. Assuming that the top nav only gets `aria-current` when user is actually on a top-level page right? (not when on any page within that top-level section)