Daniel McCloy

Results 823 comments of Daniel McCloy

@larsoner this one LGTM, I'll let you merge if happy

xrefs: - #12855 - #12795 In particular, we have permission (in https://github.com/mne-tools/mne-python/issues/12855#issue-2528909321) to basically copy / adapt the curry reader script provided by Compumedics. Can you confirm that your data...

> if [@SueJaH](https://github.com/SueJaH) is not interested i might tackle that PR [@drammock](https://github.com/drammock) . currently running into problems with curry9 cdt files, too that would be a welcome contribution!

this already works basically the same way as the left-sidebar I think? If the viewport is narrow enough, you'll get two "collapse" icons (one on each side). E.g., on this...

adding optional-left-sidebar-collapse at all screen widths is already a requested feature: #1072 (see https://github.com/pydata/pydata-sphinx-theme/issues/1072#issuecomment-2112935498 for proposed behavior / appearance). I see no reason in principle why we couldn't do something...

I agree with https://github.com/mne-tools/mne-connectivity/issues/248#issuecomment-2435902653 that auto-choosing `Reds` vs `RdBu_r` is fine, and we can/should leverage what we already have: https://github.com/mne-tools/mne-python/blob/e15292fc0bc8d5e32dd6d6099a839bf810963f3a/mne/viz/utils.py#L1422-L1430 (which I guess means we should make that function public,...

yeah sorry I meant to say that explicitly. Adding `cnorm` seems like the right move here.

Thanks for the contribution! Agree that this is an improvement. I can imagine some alternative approaches that might look better for our specific docs site (separately flex-wrapping the groups of...

> See for example the third screenshot in the PR description, the one with the long links. [this site](https://faq.gutenberg-asso.fr/index.html) (from one of our regular bug-reporters) would be a good test-bed...

> Agreed and rather than `mit_format` I'd rather have `fmt="auto"` that you could set to `"mit"` (or any of the other supported formats). If we triage based on file extension...