Daniel McCloy comments

Results 823 comments of


                                            Daniel McCloy

Highlight correct TOC entry on page load

thanks @gabalafou 🎉

DISCUSS - `0.17.0` Release

potential blockers: - [ ] there are a couple bugs noticed on #2119 that should probably get addressed before a release. - [x] #2168 looks like a moderately bad bug,...

DISCUSS - `0.17.0` Release

> Does that reasoning work for others? SGTM

DISCUSS - `0.17.0` Release

Blocker is maintainer time. Link shortening can be bumped, but AFAICT there are some things mentioned in the lists above that didn't have dedicated issues, which haven't yet been addressed.

Add a "neighbor" method to `interpolate_bads` that works without exact sensor positions

+1 for option (2). I prefer the name `"custom"` rather than `"neighbors"` for the method where users pass in a custom adjacency matrix.

Detect badly scaled plots in raw.plot, warn and propose auto-scale

I hesitate a lot about adding pop-ups like this. Is a (big, bold, all-caps?) warning in the terminal not sufficient?

Detect badly scaled plots in raw.plot, warn and propose auto-scale

> In my experience, people easily miss it when they have a GUI open, usually in front of the terminal. Another option would be a small part of the GUI...

Improve `mne.Report.add_ica` with `ica.plot_sources`

+1, I've missed having this feature recently

apply_function docstring wrong for epochs?

> I made the changes to the docstrings, but can't figure out how to test the changes by maybe viewing it in a locally hosted html file. Instructions are in...

mode parameter in get_cross_talk and get_point_spread does not work as intended

@olafhauk do you have time to look into this one?