Daniel McCloy

one other important note: now that `FunctionSortKey` returns a type (rather than an instance) it will fail sphinx's `is_serializable` checks. So might be worth highlighting that in the docs /...

> Thus I specifically removed `within_subsection_order` from the docs (see: https://sphinx-gallery.github.io/stable/configuration.html#custom-sort-keys and my last note: [#1226 (comment)](https://github.com/sphinx-gallery/sphinx-gallery/pull/1226#issuecomment-1918365134) Ah yes, I somehow missed that `within_subsection_order` wasn't mentioned in the "Custom Sort...

> > and IIUC we don't expect users to pass in an actual class right? just instances? > > It looks like at least mpl does [...] Does that change...

> > then MPL's custom sorter class should work too, and the test suite still passes locally. > > Do you see an easy enough way to modify `tinybuild` to...

> Sorry I got to this late. Would it work to alter `sphinx_gallery/tests/testconfs/src` to add a subgallery? Is it easy to 'fix' the tests that use `sphinx_wrapper_app` such that they...

ok sorting tests are fixed @lucyleeow (sorry I missed those before, thought I ran full pytest before pushing but I must not have). All green now.

> Let me know when you are done and I'll take another look. Thanks again 🙏 OK I think it's ready! I didn't touch the docs because you said you...

> I see a few minigallery directives in the new `plot` example files. Did you have plans for adding minigallery sort tests? nope, those were just copy-pasted from existing `plot_1.py`...

hmm. In order to write a test that fails on main / passes on my PR, I was hoping to be able to pass `confoverrides` to the Sphinx app ---...

that looks like it should work! Thanks, I hadn't noticed the `add_conf` pytest mark before. I'll give it a shot.