Daniel McCloy

Results 823 comments of Daniel McCloy

What is the end goal here? IIUC, the proposal is to trade complexity in the class definition (having some extra private methods defined that aren't needed by users, only devs)...

My general feeling aligns with @larsoner: > Seems like more work than it's worth to move them around / out of the class. However: if we can get it to...

This may be moot given the move to not support non-canonical URLs, but: > How would the full regex look? ```pycon In [1]: import re In [2]: path1 = "/gitlab-org/gitlab/-/merge_requests/123"...

> Honestly, I have no clue about Bitbucket. Never used it. I did a little digging. [this page](https://confluence.atlassian.com/bitbucketserver0412/markdown-syntax-guide-869179172.html) has sections on linking to issues and PRs. PRs are `projectkey/repo-slug#pr_id`. Issues...

> The problem is that GitLab namespaces can be more than two levels deep. ah. didn't know that. All makes sense now.

> > The problem is that GitLab namespaces can be more than two levels deep. > > ah. didn't know that. All makes sense now. for the record I did...

thanks for reporting. I think that `div` is supposed to be suppressed if it's empty, so the fact that it still shows up is definitely something we should fix. (or...

> I gave an example using a file from TUH EEG corpus, assuming most people in this space work with this. There are thousands of EEG/MEG datasets. not everyone is...

hmm, that site requires login. Looks like to get credentials one must fill in a form, email that form to the maintainers, and wait for a response. https://isip.piconepress.com/projects/nedc/html/tuh_eeg/

thanks for the file. I can reproduce. So far I've traced things through the importer and am not seeing any obvious culprits; haven't looked at the exporter yet. The bug...