Daniel McCloy
Daniel McCloy
> I.E. I would expect that for light mode w/ a "light" theme, it looks exactly like in the > [theme gallery](https://help.farbox.com/pygments.html) > and that for dark mode, the syntax...
> Right now for code blocks, using the same theme for light + dark mode, more is being changed than just the background color: I cannot reproduce this. I just...
right, agreed. see my edited post just above yours.
@12rambau maybe it's enough to add an example of it to our docs? I'm not sure the best place; maybe a new section on this page: https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/light-dark.html that just says...
Seems reasonable. Another possibility is to keep it as a list-of-dicts, and have users optionally add a `preferred=True` item to one entry, and similarly an optional `latest=True` to one entry....
@12rambau are you OK with the general approach of having "light" be the default styling? If so either of these options seem reasonable to me: > One way to fix...
> What do you think of adding their disabler to that script? It's just adding `data-cfasync="false"` in the tag. +1 and thanks for figuring it out!
+1 to revert #861. @choldgraf OK by you? You're the one who oversaw that one. crossref to #904 which I think was also caused by #861
> My feeling is that we don't want to block all future releases on this issue agreed. I've removed the tag. I initially added it somewhat hastily without looking closely...
incidentally, I just did this: ```console $ mamba upgrade --all $ git switch main $ git merge --ff-only upstream/main $ nox --no-reuse-existing-virtualenvs -s docs ``` and I get *lots* of...