pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

Published 20 hours ago • verified publisher icon pydata

Extra vertical whitespace padding above h1 in theme v0.10.0

Open rossbar opened this issue 1 year ago • 3 comments

I just noticed that numpydoc's documentation looks strange with the latest pydata-sphinx-theme. I built the docs locally and can confirm that the extra vertical whitespace above the main title is present w/ v0.10.0 and later.

I went ahead and bisected which ID'ed #861 as the PR which introduced the behavior change.

rossbar avatar Sep 27 '22 20:09 rossbar

+1 to revert #861. @choldgraf OK by you? You're the one who oversaw that one.

crossref to #904 which I think was also caused by #861

drammock avatar Sep 27 '22 20:09 drammock

That PR did a bunch of stuff right? Can we just revert the changes that added a UI bug?

choldgraf avatar Sep 27 '22 23:09 choldgraf

Any issues with #861 can be addressed separately. This issue can be closed with the 0.11 release and https://github.com/numpy/numpydoc/pull/434/commits/4d694446e55fae31e164f69296de8c4da5e433d7.

jarrodmillman avatar Sep 28 '22 02:09 jarrodmillman

It'd be nice not to have to annotate the rst file in the project with metadata in order to prevent the extra whitespace, so a solution within the theme itself would be preferable longer-term. Just wanted to mention that since this issue was closed!

rossbar avatar Oct 04 '22 21:10 rossbar