rubyforgood
Remove product drive delete if any donations for product drive
Summary
Remove product drive delete capability if there are any donations for the product drive.
Why?
If someone deletes a product drive with donations attached, it breaks the donations page. It appears no one ever has used this function.
Details
The button in question can be seen by signing in as [email protected], then clicking "Community', then "Product Drives", then clicking "View" on one of the product drives.
Criteria for completion
- [ ] removal of product drive delete, as described above
- [ ] automated tests to confirm
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There hasn't been any activity on the PR for this for a month, so we consider it open for someone to pick up and finish.
Hi, sorry this took so long, I made the changes but cannot figure out how to push to an existing branch in someone else's fork, should I create a new PR?
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
Hi, quick question!
I saw that the current PR uses the ProductDriveDestroyService to prevent deletion of ProductDrives with donations.
Personally, I think using the model association option dependent: :restrict_with_error would be a better fit — it’s simpler and easier to maintain.
What do you think?
