Jordan comments

Results 179 comments of


                                            Jordan

Fix allowed regions handling

fwiw this is was FAWE does for `//copy` https://github.com/IntellectualSites/FastAsyncWorldEdit/blob/main/worldedit-core/src/main/java/com/sk89q/worldedit/command/ClipboardCommands.java#L286

Instantiation of convex polyhedral region seems to not work sometimes

Try on the latest version, There have been some changes related to region block setting

Instantiation of convex polyhedral region seems to not work sometimes

Is it definitely with exactly the same order of setting the points, etc. (between WE and FAWE)? There are no differences in the region classes

fix: override min/max pos methods from SimpleClipboard

FWIW if the biome is always forest, that suggests a different issue. This PR addresses the specific issue fine

fix: replace Vault`isPluginEnabled` check with null check as plugin not necessarily enabled yet

What exactly breaks by making the same change elsewhere, e.g. for permission handler?

fix: replace Vault`isPluginEnabled` check with null check as plugin not necessarily enabled yet

IHmm okay, so I suppose the vault permissions module is just never used then, which is why permissions continue to work? It might be worth forcefully disabling it to be...

feat: implement command to fix block connections

![more_fixies](https://github.com/IntellectualSites/FastAsyncWorldEdit/assets/10080017/fffccaff-bb93-4252-a424-fb4643b87bfd)

feat: implement command to fix block connections

> The copyright header is missing in some files, no (e.g. FaweMutableBlockPlaceContext.java)? Though I'm wondering why the CI is not failing on that That should be because licences are only...

feat: implement command to fix block connections

What's the full error?

feat: implement command to fix block connections

Fixed^