domoscargin

Results 77 comments of domoscargin

We'll probably have to deal with #1081 first, since the out-of-date step by step pattern requires jQuery. It has been updated to remove the jQuery dependency (https://github.com/alphagov/govuk_publishing_components/pull/1645). If we decided...

Would updating jQuery be more or less onerous for users? I'm not entirely familiar with the major changes between v1 and v3 of jQuery, but presumably users would need to...

If we chose to update jQuery, we'd need to: * point out that users can downgrade manually at their own risk * point them to [jQuery's migration plugin](https://jquery.com/download/#jquery-migrate-plugin) to get...

UA will stop processing new hits on 1 July 2023. https://blog.google/products/marketingplatform/analytics/prepare-for-future-with-google-analytics-4/

Google have published a migration guide here: https://support.google.com/analytics/answer/10759417

When we eventually consider dropping Node 12 support, we must remember to look at our lockfile version: https://github.com/alphagov/govuk-prototype-kit/pull/1151

The original failures in the issue description have had their logs deleted due to retention limits, so here's another recent failure: ``` FAIL __tests__/search.test.js ([36](https://github.com/alphagov/govuk-design-system/runs/5452041339?check_suite_focus=true#step:7:36).145 s) ● Site search ›...

And more: ``` FAIL __tests__/cookie-banner.test.js (24.341 s) ● Cookie banner › is hidden on the cookies page thrown: "Exceeded timeout of 10000 ms for a test. Use jest.setTimeout(newTimeout) to increase...

And another: ``` ● Site search › returns results where a word in the title begins with the letter "d" expect(received).toBeTruthy() Received: false 42 | ) 43 | // regex...

Pushed a change to [retry flaky tests](https://github.com/alphagov/govuk-design-system/pull/2304). We can keep an eye on it and see if there's still issues. This is very much the "nothing to see here" approach...