domoscargin

Results 77 comments of domoscargin

We've made quite a few changes to our testing tools (mostly in terms of bumping dependencies), and haven't noticed any issues with tests for a while, so I'm going to...

Got another of these (in Windows): ```bash FAIL __tests__/search.test.js ● Site search › returns results where a word in the title begins with the letter "d" expect(received).toBeTruthy() Received: false 53...

Haven't got time to look at this today, but the problem is: 1. We're using the deprecated eslintrc.js format, so we're going to want to look at [updating that to...

Going to close this in favour of https://github.com/alphagov/govuk-frontend/issues/2717 Think we need a discussion on the current state of this to prioritise future work.

Another instance of this happening on support today, at: https://github.com/DFE-Digital/npq-prototype/blob/main/app/views/registration-status/accordion.html

Hi @adarsh-jha-dev - I've added this to our workflow so the team can take a look at it. Thanks for submitting!

As part of this, we should have a glance at our use of `Intl.NumberFormat` - we use similar guards for the two.

We have an implementation of a base class doing some work behind the scenes, but are not intending to make it public in v5. Capturing some of the thinking we've...

I had a look at this from the perspective of getting rid of the `extractPageHeadings` plugin. `getHeadingList` is only useful/available within the `marked` call, so there's some scoping issues getting...