domoscargin

Moving this back to the backlog, as its dependent on updating the compilation tasks.

I've added some more analysis to my Gulp Stuff™ Spreadsheet, looking at our NPM scripts: https://docs.google.com/spreadsheets/d/1aprdKVIx6FzBtX9ohWx6LR8p5XH3s2PNq1tev1ZwxkY/edit#gid=77403370 There's a sheet comparing the tasks our npm scripts actually perform under the hood,...

I've left a few small comments, but overall I think this looks good. It'd be good to update this sheet when this gets approved: https://docs.google.com/spreadsheets/d/1aprdKVIx6FzBtX9ohWx6LR8p5XH3s2PNq1tev1ZwxkY/edit#gid=77403370 I can't think of any...

Hey @webketje, thanks for reaching out - it's not an issue with either package, thankfully - our markdown/nunjucks is just quirky because we've been using `marked` 0.3.9 for so long.

Re: prioritsation of config passed by data attributes and config passed by JavaScript, we've decided that data attributes should always take precedence over config passed by JavaScript. https://github.com/alphagov/govuk-frontend/issues/2781

@36degrees, I've defaulted `navigationLabel` to `menuButtonText`. I've also had a go at writing a changelog entry, but it feels a bit meh to just say "don't make it too long"....

I'm thinking it'd be enough documentation-wise to edit the header.yaml `menuButtonText` description to something like: > Text for the button that toggles the navigation. This should be [the shortest useful...

@christopherthomasdesign What do you think? Does this require more design work? Or will some kind of guidance do?

I was hoping this would solve this problem with NVDA: #2055 but it looks like it's still an issue. Just popping it here for completeness - we've filed it as...

Thanks for the continued picking apart of this stuff! I can still get flaky NVDA behaviour on the [deployment](https://govuk-frontend-pr-2677.herokuapp.com/full-page-examples/passport-details), but again, I wouldn't let that stop this PR in any...