domoscargin
domoscargin
Had a brief look at `it.concurrent.each`, but at first glance this doesn't play nicely with Puppeteer. Maybe something with `promise.all`?
Darn, failed here.
I've reduced failures on this PR down to zero BUT only by disabling rules across the board. Just wanted to get this down to zero and allow us to think...
# Failures notes ## `aria-allowed-role` This flags our [use of `role="region"` on the `` element](https://github.com/alphagov/govuk-design-system/blob/d3c7b0556b8bfc9e0204220b233deae32173f62d/src/patterns/payment-card-details/index.md?plain=1#L67-L74), which doesn't allow that role. This was [done on purpose](https://github.com/alphagov/govuk-design-system/commit/686d1f16d11f2e0cb37566a50f698636da472258), but unclear if it's still...
This feels like a sensible approach - I think we definitely want to make sure we're testing for read-onliness internally. I'm less worried about the impact on `@types/govuk-frontend`, tbh.
Pretty sure I was just reacting positively to this spike! I think we had some discussions about whether, if we dropped the Object.freeze, we needed to do anything else to...
See https://github.com/alphagov/govuk-frontend/pull/5127 for 4.x - we can probably lift and shift from there.
> Made another push to tweak that last commit ([diff](https://github.com/alphagov/govuk-frontend/compare/e620b8b1a3e1f9878bdab512cc88e99d3ff5a6ea..3494a621d150c3c45fe94f394a7ab97f46aa3209)) > > Had forgotten `TaskOptions` (alias of `AssetPathOptions`) needed to stay as `@typedef` > > Since there's some `@import` added...
There is a functional PR for this, but it needs at least an accessibility pass, and we need to decide if this is still a direction we need to go...
I'm also unsure whether we should tagging branded examples anyway, since that's now the default.