Dominik Moritz
Dominik Moritz
@codler I added a tldr to the first message. Does that help?
Hi @nonara. Thank you for your comment. Your assessment of the situation is accurate. It's a lot of work to maintain this library and keep up with the development of...
If you want to see more test cases, I have accumulated a bunch of them over the years at https://github.com/vega/ts-json-schema-generator/tree/master/test/valid-data. Your examples are good and they show that `ts-json-schema-generator` works...
I think it's a pretty comprehensive test set. I'm also open to changing some of the outputs (e.g. always output aliases even if they are not exported).
Thank you for describing your approach. This sounds a lot more reliable and not too complicated. Let me know when you take a stab at it. I’m happy to even...
I think you probably just need to update the Vega-Lite test case. You can use the provided script to do it automatically.
Try `yarn test:update`
Thank you for working on this and making sure the feature is clean. I definitely think this is a good improvement.
@dmchurch do you plan to wrap this up soon?
@dmchurch can you please finish up this pull request?