Dominik Moritz

Results 1544 comments of Dominik Moritz

While it might be easier for validators, we have to consider other common use cases like generating types/classes as in http://github.com/altair-viz/altair, which is generated from the Vega-Lite schema. Since Vega-Lite...

I tried to avoid having too many knobs so far and would only be willing to accept this change with comprehensive unit tests.

Happy to review a pull request towards this goal.

I think template literal types didn't exist since recently. You could send a pull request to add a new template literal type node parser.

Eventually, yes. I'd love if you could help us by sending a pull request.

I think an additional warning is good. I'd prefer not to add a flag since it increases the api surface and it's easy enough to comment out code when debugging.

I'm not following. `containerSize` gives you the size of the container. ```json { "$schema": "https://vega.github.io/schema/vega/v5.json", "width": 400, "height": 200, "padding": 5, "signals": [ { "name": "size", "update": "containerSize()", "on": [...

I think that was before `containerSize` and better support for `autosize: 'fit'`. I think the latter should work. Have you tried it? If it doesn't work we can use JavaScript...

@kristw do you have time to update react vega?

Vega-Lite 5.1 is out.